New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Custody Count to Uint8 #14386

Merged

nisdas merged 4 commits into peerDAS from cscUint8

Aug 27, 2024

Member

nisdas commented Aug 27, 2024

What type of PR is this?

Spec Update

What does this PR do? Why is it needed?

In ethereum/consensus-specs#3897, the custody count was changed to a uint8 from a uint64 to more accurately represent its range.

Our proto Metadata type is changed to represent the custody count as a byte slice with a size of 1 from a uint64 as protobuf doesn't have a uint8 type.
This also updates our enr to use a uint8 type instead for the custody count.

Which issues(s) does this PR fix?

N.A

Other notes for review

Acknowledgements


          Add Changes for Uint8 Csc

83772fe

nisdas added the peerDAS label

nisdas requested a review from a team as a code owner

August 27, 2024 07:08

nisdas requested review from nalepae, rauljordan and prestonvanloon and removed request for a team

August 27, 2024 07:08

nisdas added 3 commits

August 27, 2024 15:10


          Fix Build

244c511


          Fix Build for Sync

25f2e6b


          Fix Discovery Test

f7abc88

nisdas merged commit f4f596a into peerDAS

13 of 16 checks passed

nisdas deleted the cscUint8 branch

August 27, 2024 07:47

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

81e336d

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

f2dea1c

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

bd7ec3f

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nisdas added a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)"

0e19d81

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

ec35840

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

419c654

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

c52fb1b

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

41f8d0a

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

ee01688

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

421d44c

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

73e4ef5

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

e833eeb

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

2fe1d90

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

ec4b1a2

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

533954f

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

4165adc

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

20ee849

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

d90c89d

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

703aae0

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

b242f40

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

db424df

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

5860c2f

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

30623aa

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

e839bb4

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

89ab9be

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

b53ef70

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

f37a90f

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

d66682c

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

a48cdfa

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

bbf2efd

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

51154ba

This reverts commit bd7ec3f.

nalepae pushed a commit that referenced this pull request


          Change Custody Count to Uint8 (#14386)

d1e43a2

* Add Changes for Uint8 Csc

* Fix Build

* Fix Build for Sync

* Fix Discovery Test

nalepae pushed a commit that referenced this pull request


          Revert "Change Custody Count to Uint8 (#14386)" (#14415)

2de1e6f

This reverts commit bd7ec3f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

Labels